Fix unclosed aiohttp.ClientResponse objects #2528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2521.
Follow-up PR after #2496. Closing sessions when exiting the
AsyncInferenceClient
is not enough to get rid of all warnings. TheClientResponse
objects also have to be closed explicitly when in case they are not consumed entirely. This PR fixes this by registering all pending responses that have to be closed when aClientSession
is closed.It was a transient error depending on when the garbage collector was triggered, making it difficult to investigate. Many thanks to @tomjorquera who provided a reproducible example. I used it to run over 100 examples (with a progress bar) and it seems resolved:
I've also added a test to ensure responses are closed when a session is closed. (and thanks to #2521, the sessions are closed when the
AsyncInferenceClient
is closed)