Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version cli command #2498

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Conversation

010kim
Copy link
Contributor

@010kim 010kim commented Aug 31, 2024

Below is the list of descriptions for this PR.

This PR is related to #2441

  1. added version.py file
  • This file is the implementation of the "huggingface-cli version" command which prints the version of the installed huggingface_hub package.
  1. updated huggingface_cli.py file
  • added VersionCommand which is implemented in the file shown above.

@010kim
Copy link
Contributor Author

010kim commented Aug 31, 2024

@Wauplin Hello! I implemented to the feature suggested by @remyleone from #2441. Could you check? Thank you in advance.

@hanouticelina hanouticelina self-requested a review September 3, 2024 09:42
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @010kim, thank you for this PR ! I let few minor comments, otherwise everything looks good to me :)

src/huggingface_hub/commands/version.py Outdated Show resolved Hide resolved
src/huggingface_hub/commands/version.py Outdated Show resolved Hide resolved
@010kim
Copy link
Contributor Author

010kim commented Sep 4, 2024

@hanouticelina Thank you so much for reviewing the PR. I fixed the typo and the variable name you mentioned. Could you check again? Thank you in advance.

@010kim 010kim requested a review from hanouticelina September 4, 2024 00:49
Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @010kim, thank you for this contribution, we are good to merge now!
cc @Wauplin

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @010kim! LGTM now :)

@hanouticelina I let you merge it once reviewed

@Wauplin
Copy link
Contributor

Wauplin commented Sep 4, 2024

Ahah, concurrent reviews ^^

@hanouticelina hanouticelina merged commit ebac1b2 into huggingface:main Sep 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants