-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version cli command #2498
Add version cli command #2498
Conversation
@Wauplin Hello! I implemented to the feature suggested by @remyleone from #2441. Could you check? Thank you in advance. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @010kim, thank you for this PR ! I let few minor comments, otherwise everything looks good to me :)
@hanouticelina Thank you so much for reviewing the PR. I fixed the typo and the variable name you mentioned. Could you check again? Thank you in advance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @010kim! LGTM now :)
@hanouticelina I let you merge it once reviewed
Ahah, concurrent reviews ^^ |
Below is the list of descriptions for this PR.
This PR is related to #2441