-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User API endpoints #2147
User API endpoints #2147
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bilgehanertan thanks a lot for your first contribution! This is really nicely implemented and documented 🔥
I just reviewed your PR. There are quite some comments but most of them are really minimal (just a matter of how to parse the data). Once those changes are done, I think we should be good to merge :)
Thank you! I will be changing them today. |
I fixed them all 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🔥 Really great job, thanks @bilgehanertan! I just realized I made a mistake in a comment yesterday. Would it be possible to add back is_pro
as attribute? Apart from that, it's ready to be merged :) Thanks in advance!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks again @bilgehanertan! I'll merge as soon as the CI is green :)
Merged it as failing test was unrelated. |
User API endpoints are implemented.
/likes
endpoint was already implemented onhf_api.py:list_liked_repos:2078
.Resolves #2077