FIX use revision in ModelHubMixin.from_pretrained#1315
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
Author
|
Thanks for taking the time to review @osanseviero :) I'm merging |
tomaarsen
added a commit
to tomaarsen/setfit
that referenced
this pull request
Nov 9, 2023
solved an issue that was causing failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1313 cc @NielsRogge.
Some legacy code in
ModelHubMixinwas acceptingrevisionas part of the model_id behind a"@"(e.g.model_id=namespace/repo_name@revision). It is the only place inhfhthat supports this pattern so I think it's best to deprecate it in favor of a properrevision=...parameter. This PR does this.Also I improved a bit the docstrings, function signatures (added typing + deprecated positional arguments) and the tests (use tmp directories everywhere instead of local fixtures dirs).
In parallel to this PR, I'll work on a guide to promote
ModelHubMixinandPyTorchModelHubMixin. At the moment, we have them documented "only" in the package reference.