-
Notifications
You must be signed in to change notification settings - Fork 390
Integrate SpanMarker library #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate SpanMarker library #737
Conversation
|
On a slightly related note - once I know that this is indeed all I have to update to integrate a library, I can certainly integrate 🤗 SetFit fully. |
osanseviero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! In general, we only merge new library PRs once we have a good number of models on the Hub, otherwise, we would have a filter button that would lead to 4 models at the moment. That said, we discussed with the team and would be ok moving this PR forward 🔥 Let's aim to grow this significantly and gets lots of models! 🥳
For completeness, we would also need to update some other sections
- Add some docs such as https://github.com/huggingface/hub-docs/blob/main/docs/hub/speechbrain.md with a brief intro (and update https://github.com/huggingface/hub-docs/blob/main/docs/hub/_toctree.yml to make sure this is included
- Add library to list of tasks https://github.com/huggingface/hub-docs/blob/main/tasks/src/const.ts#L43
- Add library to following table https://github.com/huggingface/hub-docs/blob/main/docs/hub/models-libraries.md?plain=1#L30
|
@osanseviero On that topic, I was wondering how you handle versioning? I intend to release v1.0.0 this month, which may or may not be backwards compatible with v0.X.X models. Currently, most v0.X.X models are my own, so I'm not completely sure whether I should messy up my codebase for backwards compatibility. May I assume that the version used for e.g. Inference Endpoints is always the most recent version? I'll add the other changes that you mention to this PR. Then, perhaps it is best if I convert this PR to a draft until v1.0.0 later this month, especially if the implementation of backwards compatibility for v0.X.X to v1.0.0 adds too much bloat.
|
Ideally the library should maintain backwards compatibility, but it might be ok to break things if the library is in a very early stage and usage is not large yet. When we do backwards compatible changes, we go through a deprecation period so people get warnings and we provide proper time to update code. As for Inference API, it will use the version pinned in the |
osanseviero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks a lot! I left a question and then we can merge
|
The documentation is not available anymore as the PR was closed or merged. |
|
I'll do my best to maintain backwards compatibility where possible, but I may go for some breaking changes before v1.0.0, i.e. before people find out about the project. On that topic, it may be best to keep this as a draft until the v1.0.0. That way, we'll limit the harm as people won't know about SpanMarker until the v1 release yet. |
|
Up to you! I think it makes sense until official release before merging this |
|
Agreed. I'll draft this and I'll report back when it's ready! Thanks for the help so far ❤️ |
…ntegration/span_marker
1. This is more in line with the other libraries, and 2. my codebase has been using 'span-marker' from the start. If I stick with span_marker, then all models will get the 'span_marker' AND 'span-marker' tags.
|
SpanMarker just released with v1.0.0, so I'm ready to get this integration merged! |
osanseviero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! 🔥
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Hello!
Pull Request overview
Details
SpanMarker is a model architecture for Named Entity Recognition that is tightly implemented on top of transformers. Consequently, loading a SpanMarker model, e.g.
tomaarsen/span-marker-bert-base-fewnerd-fine-superis as simple as:Feel free to try out this Space to get a feel for the power of the architecture.
I've followed the documentation here, but it wasn't extremely clear on which sections should be added for a succesful integration, so please let me know if I forgot any parts.
This PR is related to huggingface/api-inference-community#225, which adds support for SpanMarker models to API Inference endpoints.