Update streamlit iframe to working hf space #1364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
reviewed
Aug 7, 2024
Comment on lines
-101
to
-102
| Please note that we have added `?embed=true` to the URL, which activates the embed mode of the Streamlit app, removing some spacers and the footer for slim embeds. | ||
|
|
There was a problem hiding this comment.
is this not relevant anymore? (im not sure)
There was a problem hiding this comment.
Not when when i updated the hf spaces in kornias docs as e.g. here (it is live): https://github.com/kornia/kornia/pull/2964/files#diff-bec16dbe99a3892599bb805746d7f3e56135fe05df0166f4fc2d86cf9ab22b5e
Also checked here: https://huggingface.co/docs/hub/spaces-embed#embedding-with-iframes where it also does not seem to be necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the streamlit iframe link to point to a working streamlit space.
Closes: #1363