Add back accelerate compatibility#339
Conversation
|
I've only tested this with the ui, yet, so it might be something on my side that is missing, or a config issue. But I'm still using "pretrained_model_name_or_path", which I think might be relevant to this: File "/finetrainers/train.py", line 70, in main |
|
Oh oops, looks like I missed a comma somewhere. Taking a look Edit: fixed in #341 |
|
Accelerate compatibility should be back now. Only did some mini-runs for now and starting a 1000-step run to verify correctness: https://wandb.ai/aryanvs/finetrainers-debug PTD vs Accelerate loss curves (grey vs maroon): The token count and order of data did not match up for both. This most likely suggests to me that there is a difference of determinism between the two for dataset, which needs to be further investigated in future. |

A few PRs ago (don't recall which exactly), I had to remove accelerate compatibility for a feature. This PR adds accelerate compatibility again and does a major refactor.