Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controlnet_sd3 parameters updated #9977

Closed

Conversation

bigbraindump
Copy link

What does this PR do?

Adds 2 additional expected parameters dual_attention_layers and qk_norm to the SDControlNetModel class. The necessary parameters are defined by the SD3Transformer2DModel introduced in SD3.

Fixes #9974

Before submitting

Who can review?

@sayakpaul

@sayakpaul
Copy link
Member

While I understand this will enable the community to do ControlNet SD3.5 training / inference, it might be also nice to check if there's an existing one already. No worries if not.

@bigbraindump
Copy link
Author

ah i see, misunderstood the question on the issue. there only seems to be pr #8566 addressing controlnet SD3 training.

@bigbraindump bigbraindump deleted the controlnet-param-update branch November 21, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add expected parameters to controlnet_sd3
2 participants