[advanced flux training] bug fix + reduce memory cost as in #9829 #9838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
linoytsaban
commented
Nov 1, 2024
•
linoytsaban
commented
- add quick fix to reduce memory cost as proposed in: Reduce Memory Cost in Flux Training #9829 for the advanced flux training script
- fix bug when training TE w/o custom prompts and batch size > 1
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Thanks! Did you run a quick experiment just to be sure? |
linoytsaban
changed the title
|
@sayakpaul gentle ping :) |
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
) * memory improvement as done here: #9829 * fix bug * fix bug * style --------- Co-authored-by: Sayak Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.