Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CogVideoX mentions from single file docs; Test updates #9444

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Remove CogVideoX mentions from single file docs; Test updates #9444

merged 4 commits into from
Sep 17, 2024

Conversation

a-r-r-o-w
Copy link
Member

What does this PR do?

CogVideoX doesn't support single file loading - I overlooked these changes so removing them now. The tests are also more correct now.

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sayakpaul @yiyixuxu

yiyixuxu
yiyixuxu approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I got confused by the comments, I think we only need to add the notes to i2v video where we have to adjust the sample_size when use a different image resolution

tests/pipelines/cogvideo/test_cogvideox.py Outdated Show resolved Hide resolved
tests/pipelines/cogvideo/test_cogvideox_video2video.py Outdated Show resolved Hide resolved
yiyixuxu
yiyixuxu approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu yiyixuxu merged commit ba06124 into main Sep 17, 2024
15 checks passed
@yiyixuxu yiyixuxu deleted the cogvideox/followups branch September 17, 2024 20:05
leisuzz pushed a commit to leisuzz/diffusers that referenced this pull request Oct 11, 2024
@a-r-r-o-w
Remove CogVideoX mentions from single file docs; Test updates (huggin…
cce0f0c 
…gface#9444)

* remove mentions from single file

* update tests

* update
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
@a-r-r-o-w @sayakpaul
Remove CogVideoX mentions from single file docs; Test updates (#9444)
0494cbd 
* remove mentions from single file

* update tests

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiyixuxu yiyixuxu yiyixuxu approved these changes

@sayakpaul sayakpaul Awaiting requested review from sayakpaul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-r-r-o-w @yiyixuxu