Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] add LoraLoaderMixin to the inits #8981

Merged
merged 62 commits into from
Jul 26, 2024
Merged

[Chore] add LoraLoaderMixin to the inits #8981

merged 62 commits into from
Jul 26, 2024

Conversation

sayakpaul
Copy link
Member

What does this PR do?

So that this doesn't happen #8975.

LoraLoaderMixin was properly deprecated in #8774. But we forgot to add that to the inits which is what caused the failures. This should be fixed now.

@sayakpaul sayakpaul requested a review from yiyixuxu July 26, 2024 01:58
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul sayakpaul merged commit d87fe95 into main Jul 26, 2024
18 checks passed
@sayakpaul sayakpaul deleted the feat-lora-base-class branch July 26, 2024 03:29
sayakpaul added a commit that referenced this pull request Dec 23, 2024
* introduce  to promote reusability.

* up

* add more tests

* up

* remove comments.

* fix fuse_nan test

* clarify the scope of fuse_lora and unfuse_lora

* remove space

* rewrite fuse_lora a bit.

* feedback

* copy over load_lora_into_text_encoder.

* address dhruv's feedback.

* fix-copies

* fix issubclass.

* num_fused_loras

* fix

* fix

* remove mapping

* up

* fix

* style

* fix-copies

* change to SD3TransformerLoRALoadersMixin

* Apply suggestions from code review

Co-authored-by: Dhruv Nair <[email protected]>

* up

* handle wuerstchen

* up

* move lora to lora_pipeline.py

* up

* fix-copies

* fix documentation.

* comment set_adapters().

* fix-copies

* fix set_adapters() at the model level.

* fix?

* fix

* loraloadermixin.

---------

Co-authored-by: Dhruv Nair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants