[LoRA] fix conversion utility so that lora dora loads correctly #8688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
commented
Jun 25, 2024
| @@ -214,7 +214,7 @@ def _convert_non_diffusers_lora_to_diffusers(state_dict, unet_name="unet", text_ | |||
| if len(state_dict) > 0: | |||
| raise ValueError(f"The following keys have not been correctly renamed: \n\n {', '.join(state_dict.keys())}") | |||
|
|
|||
| logger.info("Kohya-style checkpoint detected.") | |||
| logger.info("Non-diffusers checkpoint detected.") | |||
There was a problem hiding this comment.
At this point a checkpoint can be of any supported type: BenTrainer, Kohya, OneTrainer, etc.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
yiyixuxu
approved these changes
Jun 26, 2024
|
Failing test is unrelated. |
sayakpaul
added a commit
that referenced
this pull request
Jun 27, 2024
fix conversion utility so that lora dora loads correctly
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
fix conversion utility so that lora dora loads correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I broke the external DoRA checkpoint loading support in #8295. Not sure how it got slipped in my testing. From https://github.com/huggingface/diffusers/actions/runs/9654288185/jobs/19382757500/summary_raw, I checked that the integration was broken.
This PR fixes that.