Skip to content

Conversation

@stevhliu
Copy link
Member

@stevhliu stevhliu commented Apr 23, 2024

This PR refactors "Combine image brightness" and "Improve image generation quality with FreeU" into one doc that is focused on improving image quality in general. Since image quality encompasses aspects such as lighting and details, I think this makes more sense than having two separate standalone docs about a particular topic.

Also adds enable_freeu and disable_freeu to the API docs.

todo

  • generate images from code snippets

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu requested review from sayakpaul and yiyixuxu April 23, 2024 22:07
specific language governing permissions and limitations under the License.
-->

# Enhance image quality
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally in love with this title so I'm open to any suggestions you may have!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Controlling image quality"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that could be good as well, thanks! :) I'll leave this PR open a few more days to allow others to chime in before merging.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

specific language governing permissions and limitations under the License.
-->

# Enhance image quality
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Controlling image quality"?

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@yiyixuxu
Copy link
Collaborator

cc @asomoza for awareness

@stevhliu stevhliu merged commit fa750a1 into huggingface:main Apr 25, 2024
@stevhliu stevhliu deleted the image-quality branch April 25, 2024 23:55
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
* refactor

* code snippets

* fix path

* fix path in guide

* code outputs

* align toctree title

* title

* fix title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants