[IP-Adapter] Fix IP-Adapter Support and Refactor Callback for StableDiffusionPanoramaPipeline
#7262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anoramaPipeline`
tolgacangoz
changed the title
IP-Adapter] Add properties and IPAdapterTesterMixin tests for StableDiffusionPanoramaPipelineIP-Adapter] Fix IP Adapter Support for Panorama Pipeline
tolgacangoz
changed the title
IP-Adapter] Fix IP Adapter Support for Panorama PipelineIP-Adapter] Fix IP-Adapter Support for Panorama Pipeline
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
|
Contributor
Author
|
The last commit seems to resolve the issue. Now, I am working on adding |
tolgacangoz
changed the title
IP-Adapter] Fix IP-Adapter Support for Panorama PipelineIP-Adapter] Fix IP-Adapter Support and Refactor 📞🔙 for Panorama Pipeline
tolgacangoz
changed the title
IP-Adapter] Fix IP-Adapter Support and Refactor 📞🔙 for Panorama PipelineIP-Adapter] Fix IP-Adapter Support and Refactor Callback for Panorama Pipeline
tolgacangoz
changed the title
IP-Adapter] Fix IP-Adapter Support and Refactor Callback for Panorama PipelineIP-Adapter] Fix IP-Adapter Support and Refactor Callback for StableDiffusionPanoramaPipeline
Contributor
Author
|
@yiyixuxu Here is ready for a review. |
Collaborator
|
can you make sure the quality tests pass? |
Contributor
Author
|
Done! |
Contributor
Author
|
There were 2 errors. One went away when I merged with the main branch and the other seems irrelevant to me in terms of this PR. FAILED tests/pipelines/test_pipelines.py::CustomPipelineTests::test_remote_components
- ImportError: cannot import name 'PositionNet' from 'diffusers.models.embeddings'
(/__w/diffusers/diffusers/src/diffusers/models/embeddings.py) |
Contributor
Author
|
Thanks for merging! |
AbhinavGopal
pushed a commit
to AbhinavGopal/diffusers
that referenced
this pull request
Mar 27, 2024
…leDiffusionPanoramaPipeline` (huggingface#7262) * Add properties and `IPAdapterTesterMixin` tests for `StableDiffusionPanoramaPipeline` * Update torch manual seed to use `torch.Generator(device=device)` * Refactor 📞🔙 to support `callback_on_step_end` * make fix-copies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7064 for
StableDiffusionPanoramaPipeline.It looks like most of the work has already been done.
StableDiffusionPanoramaPipelineclass seems to pass the tests ofIPAdapterTesterMixinin my local setup.Thanks for this opportunity!
@yiyixuxu