Skip to content

Conversation

@viettmab
Copy link
Contributor

What does this PR do?

Fixes #6702

Before submitting

Who can review?

@sayakpaul

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much.

Cc: @bram-w and @radames.

@sayakpaul
Copy link
Member

Will merge after the CI is green.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul
Copy link
Member

I think the failing tests are unrelated. Could you push an empty commit?

@viettmab
Copy link
Contributor Author

@sayakpaul, I've pushed an empty commit as you suggested. Could you please check it again? Thanks!

@sayakpaul
Copy link
Member

Failing test is unrelated.

@sayakpaul sayakpaul merged commit 1cab64b into huggingface:main Jan 31, 2024
@sayakpaul
Copy link
Member

Thanks for your contributions.

dg845 pushed a commit to dg845/diffusers that referenced this pull request Feb 2, 2024
* Update train_diffusion_dpo.py

Address huggingface#6702

* Update train_diffusion_dpo_sdxl.py

* Empty-Commit

---------

Co-authored-by: Sayak Paul <[email protected]>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* Update train_diffusion_dpo.py

Address huggingface#6702

* Update train_diffusion_dpo_sdxl.py

* Empty-Commit

---------

Co-authored-by: Sayak Paul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Diffusion DPO] Loss function and reproducing results in the paper

3 participants