Change os.path to pathlib Path #6737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
reviewed
Jan 28, 2024
| if os.path.isdir(model_id): | ||
| model = OnnxRuntimeModel.load_model( | ||
| os.path.join(model_id, model_file_name), provider=provider, sess_options=sess_options | ||
| Path(model_id, model_file_name).as_posix(), provider=provider, sess_options=sess_options |
Member
There was a problem hiding this comment.
Don't we need to import Path?
Contributor
Author
There was a problem hiding this comment.
Yes, but it's already imported because Path is also being used in other parts of the file
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
Change os.path to pathlib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces Posix to provide stronger support for Windows compatibility. Changes the instance of os.path.join() to Path(...).as_posix().
Fixes #6585
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul