[Training] make DreamBooth SDXL LoRA training script compatible with torch.compile #6483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| prompt_embeds = text_encoder( | ||
| text_input_ids.to(text_encoder.device), | ||
| output_hidden_states=True, | ||
| text_input_ids.to(text_encoder.device), output_hidden_states=True, return_dict=False |
Contributor
There was a problem hiding this comment.
Why do we need to add output_hidden_states=True here?
Member
Author
There was a problem hiding this comment.
It was already there. Look again, please.
Member
Author
There was a problem hiding this comment.
True here too:
Contributor
There was a problem hiding this comment.
Ah sorry yeah indeed we need it! Thanks for double-checking
Contributor
patrickvonplaten
left a comment
patrickvonplaten
left a comment
There was a problem hiding this comment.
Very good idea to add return_dict=False everywhere, I don't fully understand why we set output_hidden_states=True here
Member
Author
|
@patrickvonplaten mergeable now? |
patrickvonplaten
approved these changes
Jan 9, 2024
This was referenced Jan 9, 2024
6 tasks
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…torch.compile (huggingface#6483) * make it torch.compile comaptible * make the text encoder compatible too. * style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the DreamBooth SDXL LoRA compatible with
torch.compile(). This has been requested by the community for a while.My
accelerateconfig:I think this PR can definitely serve as a reference for contributors willing to do this for the other scripts (I will create an issue for that later).