Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Tighten up LoRA loading relaxation #4787

Merged
merged 3 commits into from
Aug 26, 2023
Merged

[Tests] Tighten up LoRA loading relaxation #4787

merged 3 commits into from
Aug 26, 2023

Conversation

sayakpaul
Copy link
Member

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 26, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

patrickvonplaten
patrickvonplaten approved these changes Aug 26, 2023
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit :-)

@sayakpaul @patrickvonplaten
Update src/diffusers/loaders.py
86b452f 
Co-authored-by: Patrick von Platen <[email protected]>
@sayakpaul sayakpaul merged commit 0de35e4 into main Aug 26, 2023
@sayakpaul sayakpaul deleted the fix/lora-ckpt-relaxation branch August 26, 2023 09:31
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@sayakpaul @patrickvonplaten
[Tests] Tighten up LoRA loading relaxation (huggingface#4787)
790f954 
* debugging

* better logic for filtering.

* Update src/diffusers/loaders.py

Co-authored-by: Patrick von Platen <[email protected]>

---------

Co-authored-by: Patrick von Platen <[email protected]>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@sayakpaul @patrickvonplaten
[Tests] Tighten up LoRA loading relaxation (huggingface#4787)
274c327 
* debugging

* better logic for filtering.

* Update src/diffusers/loaders.py

Co-authored-by: Patrick von Platen <[email protected]>

---------

Co-authored-by: Patrick von Platen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sayakpaul @HuggingFaceDocBuilderDev @patrickvonplaten