Clean up flaky behaviour on Slow CUDA Pytorch Push Tests #4759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain Mixin Classes and Tests use the sum of the absolute differences between two an expected and output tensor to check if the models/pipelines are behaving as expected. e.g
Using sum leads to more flaky testing behaviour due since small differences over many individual values in the tensors accumulate. Proposing to move this to use the maximum absolute difference between tensors instead.
e.g
Additionally, the
PipelineTesterMixin
has a some tests:test_from_save_pretrained, test_from_save_pretrained_variant, test_save_load_float16
etc that tests against precision tolerances but do not currently allow the pipelines inheriting from them to pass in custom precision values, which is leading to a number of failures. This PR adds anexpected_max_diff
argument to each of these tests to control the precision level.Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.