Replaces DIFFUSERS_TEST_DEVICE backend list with trying device
#4673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a better method than comparing against a list of supported backends as it allows for supporting any number of backends provided they are installed on the user's system. This should have no effect on the behaviour of tests in Huggingface's CI workers. See transformers#25506 where this approach has already been added.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
Nice work @vvvm23 💪🏽 |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…gingface#4673) This is a better method than comparing against a list of supported backends as it allows for supporting any number of backends provided they are installed on the user's system. This should have no effect on the behaviour of tests in Huggingface's CI workers. See transformers#25506 where this approach has already been added.
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…gingface#4673) This is a better method than comparing against a list of supported backends as it allows for supporting any number of backends provided they are installed on the user's system. This should have no effect on the behaviour of tests in Huggingface's CI workers. See transformers#25506 where this approach has already been added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a better method than comparing against a list of supported backends as it allows for supporting any number of backends provided they are installed on the user's system. This should have no effect on the behaviour of tests in Huggingface's CI workers. See transformers#25506 where this approach has already been added.
What does this PR do?
Changes method of verifying provided test device (via
DIFFUSERS_TEST_DEVICE) is valid by simply trying to create the device. This approach is now also used in transformers#25506.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@patrickvonplaten @sayakpaul