Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference_attn & reference_adain support for sdxl #4502

Merged
merged 20 commits into from
Aug 22, 2023
Merged

Add reference_attn & reference_adain support for sdxl #4502

merged 20 commits into from
Aug 22, 2023

Conversation

zideliu
Copy link
Contributor

@zideliu zideliu commented Aug 7, 2023

What does this PR do?

It provides reference support for sdxl model, based on stable_diffusion_reference

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

examples/community/README.md Outdated Show resolved Hide resolved
@DN6
Copy link
Collaborator

DN6 commented Aug 21, 2023

@zideliu PR looks good. Could you provide some example generations from the pipelines to add to the README so that other users can see the expected types of output from the pipeline.

@zideliu
Copy link
Contributor Author

zideliu commented Aug 21, 2023

@zideliu PR looks good. Could you provide some example generations from the pipelines to add to the README so that other users can see the expected types of output from the pipeline.

OK!

@DN6
Copy link
Collaborator

DN6 commented Aug 22, 2023

Thanks for adding the examples @zideliu. I took a look at them, but I can't seem to see any difference between the output image and reference image. Is it possible to try creating an output image where the difference is more obvious?

@zideliu
Copy link
Contributor Author

zideliu commented Aug 22, 2023

Thanks for adding the examples @zideliu. I took a look at them, but I can't seem to see any difference between the output image and reference image. Is it possible to try creating an output image where the difference is more obvious?

Done !

Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@DN6
Copy link
Collaborator

DN6 commented Aug 22, 2023

@zideliu Nicely done. Could you run make quality && make style so that the code quality checks pass. We should be ready to merge then.

@zideliu
Copy link
Contributor Author

zideliu commented Aug 22, 2023

OK ~

@DN6 DN6 merged commit f22aad6 into huggingface:main Aug 22, 2023
@DN6
Copy link
Collaborator

DN6 commented Aug 22, 2023

Nice job @zideliu 👍🏽

@blx0102
Copy link

blx0102 commented Aug 28, 2023

I tried some images, but the result somehow not really good, the face is usually distorted. Is this normal?
screenshot-20230828-152256

@zideliu
Copy link
Contributor Author

zideliu commented Aug 28, 2023

Try increasing inference_steps, such as 50

@blx0102
Copy link

blx0102 commented Aug 31, 2023

@zideliu Have tried but it didn't help

AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* ADD SDXL reference & reference adain

* Update README.md

* Update README.md

* format stable_diffusion_xl_reference.py

* format file

* Format file

* format file

* fix format

* fix format with ruff

* fix format

* Update examples/community/README.md

Co-authored-by: Dhruv Nair <[email protected]>

* Update examples/community/README.md

Co-authored-by: Dhruv Nair <[email protected]>

* Update README.md

* Update README.md & fix typo

* Update README.md

* fix format

---------

Co-authored-by: Dhruv Nair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants