change validation scheduler for train_dreambooth.py when training IF #4333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
if we want to make the scheduler configurable, I would prefer if the flag was to set a particular scheduler via a string instead of an adhoc override. Can you change the pr to pass a (pseudocode) |
|
I use eval(args.validation_scheduler) to call DPMSolverMultistepScheduler. But the check reports: examples/dreambooth/train_dreambooth.py:50:5: F401 [*] |
|
Could we maybe work with importlib here instead of Python's |
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…uggingface#4333) * dreambooth training * train_dreambooth validation scheduler * set a particular scheduler via a string * modify readme after setting a particular scheduler via a string * modify readme after setting a particular scheduler * use importlib to set a particular scheduler * import with correct sort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4313
Who can review?
cc @sayakpaul and @williamberman for dreambooth