[SDXL Refiner] Fix refiner forward pass for batched input #4327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
changed the title
|
The documentation is not available anymore as the PR was closed or merged. |
tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl_inpaint.py
Outdated
Show resolved
Hide resolved
bghira
reviewed
Jul 27, 2023
| @@ -906,15 +906,17 @@ def denoising_value_valid(dnv): | |||
| negative_aesthetic_score, | |||
| dtype=prompt_embeds.dtype, | |||
| ) | |||
| add_time_ids = add_time_ids.repeat(batch_size * num_images_per_prompt, 1) | |||
There was a problem hiding this comment.
those blasted timestep embeds!
|
there's now minimal differences in the outputs for bs1 and bs2 :)
bonus, we can now see the kid's face a bit better: |
|
Ran a batch size of 2 with the invisible-watermark, eg. this is do_latents = False, just to ensure it's not a problem.
|
bghira
approved these changes
Jul 28, 2023
|
Hmm sadly the email address doesn't seem to work for co-authorship. Hope the PR description is enough credit here :-) |
|
Merging! Many thanks for bearing with me yesterday evening @bghira ! |
|
the fact it means i wasnt crazy, meant the world to me ahaha |
sayakpaul
pushed a commit
that referenced
this pull request
Jul 28, 2023
* fix_batch_xl * Fix other pipelines as well * up * up * Update tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl_inpaint.py * sort * up * Finish it all up Co-authored-by: Bagheera <[email protected]> * Co-authored-by: Bagheera [email protected] * Co-authored-by: Bagheera <[email protected]> * Finish it all up Co-authored-by: Bagheera <[email protected]>
orpatashnik
pushed a commit
to orpatashnik/diffusers
that referenced
this pull request
Aug 1, 2023
…e#4327) * fix_batch_xl * Fix other pipelines as well * up * up * Update tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl_inpaint.py * sort * up * Finish it all up Co-authored-by: Bagheera <[email protected]> * Co-authored-by: Bagheera [email protected] * Co-authored-by: Bagheera <[email protected]> * Finish it all up Co-authored-by: Bagheera <[email protected]>
orpatashnik
pushed a commit
to orpatashnik/diffusers
that referenced
this pull request
Aug 1, 2023
…e#4327) * fix_batch_xl * Fix other pipelines as well * up * up * Update tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl_inpaint.py * sort * up * Finish it all up Co-authored-by: Bagheera <[email protected]> * Co-authored-by: Bagheera [email protected] * Co-authored-by: Bagheera <[email protected]> * Finish it all up Co-authored-by: Bagheera <[email protected]>
orpatashnik
pushed a commit
to orpatashnik/diffusers
that referenced
this pull request
Aug 1, 2023
…e#4327) * fix_batch_xl * Fix other pipelines as well * up * up * Update tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl_inpaint.py * sort * up * Finish it all up Co-authored-by: Bagheera <[email protected]> * Co-authored-by: Bagheera [email protected] * Co-authored-by: Bagheera <[email protected]> * Finish it all up Co-authored-by: Bagheera <[email protected]>
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…e#4327) * fix_batch_xl * Fix other pipelines as well * up * up * Update tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl_inpaint.py * sort * up * Finish it all up Co-authored-by: Bagheera <[email protected]> * Co-authored-by: Bagheera [email protected] * Co-authored-by: Bagheera <[email protected]> * Finish it all up Co-authored-by: Bagheera <[email protected]>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…e#4327) * fix_batch_xl * Fix other pipelines as well * up * up * Update tests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl_inpaint.py * sort * up * Finish it all up Co-authored-by: Bagheera <[email protected]> * Co-authored-by: Bagheera [email protected] * Co-authored-by: Bagheera <[email protected]> * Finish it all up Co-authored-by: Bagheera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As found by @bghira in #4297 there was a small bug for the refiner when the batch size > 1.
For certain use cases (low steps, high precision) the bug led to serious artifacts as seen in #4297
We also adapt the tests here to make sure the refiner is correctly tested going forward.