Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP-Adapter example to Flux docs #10633

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

hlky
Copy link
Collaborator

@hlky hlky commented Jan 23, 2025

What does this PR do?

Pending https://huggingface.co/datasets/huggingface/documentation-images/discussions/424

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@hlky hlky requested review from sayakpaul and stevhliu January 23, 2025 08:54
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some comments.


</Tip>

An IP-Adapter lets you prompt Flux with images, in addition to the text prompt. This is especially useful when describing complex concepts that are difficult to articulate through text alone and you have reference images.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be beneficial to make note on how it's different from Redux.

docs/source/en/api/pipelines/flux.md Outdated Show resolved Hide resolved
docs/source/en/api/pipelines/flux.md Outdated Show resolved Hide resolved
Comment on lines +345 to +346
negative_prompt="",
true_cfg=4.0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need CFG to get reasonable results?

Copy link
Collaborator Author

@hlky hlky Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For v1 yes, for v2 no but results are not as good. See #10261 I didn't do much testing, these are the original examples, I prefer v1 but could be a matter of playing with the strength schedules in v2.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sayakpaul sayakpaul merged commit 37c9697 into huggingface:main Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants