-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Return local paths to Common Voice #3664
Closed
Closed
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f247982
Merge generators for local files and streaming
anton-l e3fc32a
Merge remote-tracking branch 'upstream/master' into return-commonvoic…
lhoestq 47a124e
revert
lhoestq 614f1c6
rollback to good ol' iter_archive with local paths
lhoestq 160c507
set local path
lhoestq 9c9bb09
remove unused import
lhoestq a74060f
fix test
lhoestq bf0765a
update for dummy data files
lhoestq 3d67e8f
Merge remote-tracking branch 'upstream/master' into return-commonvoic…
lhoestq d7b8136
fix air dialogue
polinaeterna 929c9dd
fix vivos
polinaeterna 4037c0c
fix speech_commands
polinaeterna 238360e
fix openslr
polinaeterna 162a8f0
fix id_nergrit_corpus
polinaeterna 64dfe64
fix imdb
polinaeterna 827360a
fix klue
polinaeterna 57fdb19
fix lama
polinaeterna ab10712
fix lex glue
polinaeterna c12c040
fix amazon polarity
polinaeterna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key part: if we get an archive files iterator, then use the new streaming logic, otherwise use the old pre-streaming logic.