Skip to content

Support exif images#2605

Merged
mariosasko merged 2 commits intomainfrom
support-exif-images
Mar 18, 2024
Merged

Support exif images#2605
mariosasko merged 2 commits intomainfrom
support-exif-images

Conversation

@mariosasko
Copy link
Contributor

The EXIF orientation tag is currently ignored when displaying images (see https://huggingface.co/datasets/mariosasko/exif_image).

This PR should fix this.

Copy link
Collaborator

@severo severo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think it's OK without a test, as it's only applying a PIL method.

@mariosasko mariosasko merged commit 64ef835 into main Mar 18, 2024
@mariosasko mariosasko deleted the support-exif-images branch March 18, 2024 22:01
@severo
Copy link
Collaborator

severo commented Mar 18, 2024

@mariosasko have you identified datasets where the images appear rotated in the dataset viewer? ie. datasets that we should refresh in priority after deploying

@lhoestq
Copy link
Member

lhoestq commented Mar 19, 2024

fix on the datasets side too: huggingface/datasets#6739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants