Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
stevhliu
approved these changes
Dec 2, 2024
Member
stevhliu
left a comment
stevhliu
left a comment
There was a problem hiding this comment.
Thanks again, you're the best! 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue with the doc build: the notebook
https://github.com/huggingface/cookbook/blob/main/notebooks/ko/structured_generation.ipynbcontains some tabulations that should actually be spaces.It also compresses the images in the notebook
https://github.com/huggingface/cookbook/blob/main/notebooks/ko/advanced_ko_rag.ipynbso that the notebook size is decreased from 9.5MB to 2.7MB. I did that because I first thought the doc build problem came from a memory issue. That's not the case but that's free notebook compression so it will be easier to visualize on Github.Who can review?
Feel free to tag members/contributors who may be interested in your PR.