Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: load discussion #1027

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

KartikGS
Copy link
Contributor

fixes #945

Adding Infinite scroll

Limit_15_for_demo.webm

@nsarrazin nsarrazin self-requested a review April 19, 2024 07:50
@nsarrazin
Copy link
Collaborator

This looks super cool thanks!! Will review

@KingNish24
Copy link
Contributor

Adding Infinite scroll

@KartikGS How you tested it?? Can you please tell

@KartikGS
Copy link
Contributor Author

Adding Infinite scroll

@KartikGS How you tested it?? Can you please tell

Currently 300 conversations are being fetched. Reduce the limit and total to 15, set extra to 3 and make sure you have enough conversations

@nsarrazin
Copy link
Collaborator

Tested this locally works great 🔥 Thanks for an awesome PR. Could you explain to me some small aspects of the code ? Mostly:

  • Why did you need an extra store convUpdate ?
  • What is the issue you were fixing with the extraConversation array and passing "extra" as a param to fetchData ? Something with consistency but I can't figure it out just looking at the code. 👀

Not saying any of this is wrong BTW, just trying to fully get it before merging 😁

@KartikGS
Copy link
Contributor Author

convUpdate- After starting a new conversation consistency is maintained as fetchData is called, that is not the case when you continue or retry conversations in extraConversations. Using the new store to deal with this.

extraConversation and ”extra”- I don’t know what you are referring to, but here I don’t want pass limit = 0 and fetch all conversations.

Sorry if I misunderstood something 😅. Feel free to ask or correct me if I’m wrong.

@SvCy
Copy link

SvCy commented May 21, 2024

shouldn't this have been merged already?

@nsarrazin nsarrazin added enhancement New feature or request back This issue is related to the Svelte backend or the DB labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back This issue is related to the Svelte backend or the DB enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation: Load more discussions
4 participants