Skip to content

Conversation

@xianbaoqian
Copy link
Contributor

Context huggingface/hub-docs#552 (comment)

It's called k2_sherpa in the inference API but in the repos, people just use k2 so let's make it consistent so that the export script can work.

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it might require some changes in api-inference-community.

@Narsil I don't see k2 in places such as https://github.com/huggingface/api-inference/blob/main/master/app/types.py#L21, but the API works. How come? :D

@@ -1,10 +1,10 @@
# TODO: Merge this with allenNLP to have a single workflow for all docker images.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a second workflow as this one? https://github.com/huggingface/api-inference-community/blob/main/.github/workflows/python-api-flair-cd.yml

That will enabled continuous deployment

@xianbaoqian
Copy link
Contributor Author

xianbaoqian commented Dec 14, 2022

LGTM but it might require some changes in api-inference-community.

@Narsil I don't see k2 in places such as https://github.com/huggingface/api-inference/blob/main/master/app/types.py#L21, but the API works. How come? :D

Yeah. I'm curious about this too. I had a quick code search on the repo but didn't find many things. This repo has k2 tag but the inference API is working.

https://huggingface.co/csukuangfj/icefall-asr-librispeech-pruned-transducer-stateless3-2022-05-13
image

@Narsil
Copy link
Contributor

Narsil commented Dec 15, 2022

@Narsil
Copy link
Contributor

Narsil commented Dec 15, 2022

The rename should work.

@Narsil
Copy link
Contributor

Narsil commented Dec 15, 2022

The rename should work.

Unfortunately the build is now broken, I don't know what maintainers have done.

Copy link
Contributor

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xianbaoqian
Copy link
Contributor Author

Thanks for fixing the bug @Narsil !

@xianbaoqian xianbaoqian merged commit 88713d1 into main Dec 15, 2022
@xianbaoqian xianbaoqian deleted the xianbao-k2 branch December 15, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants