-
Notifications
You must be signed in to change notification settings - Fork 67
Rename k2_sherpa to k2 #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
osanseviero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but it might require some changes in api-inference-community.
@Narsil I don't see k2 in places such as https://github.com/huggingface/api-inference/blob/main/master/app/types.py#L21, but the API works. How come? :D
| @@ -1,10 +1,10 @@ | |||
| # TODO: Merge this with allenNLP to have a single workflow for all docker images. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding a second workflow as this one? https://github.com/huggingface/api-inference-community/blob/main/.github/workflows/python-api-flair-cd.yml
That will enabled continuous deployment
Yeah. I'm curious about this too. I had a quick code search on the repo but didn't find many things. This repo has k2 tag but the inference API is working. https://huggingface.co/csukuangfj/icefall-asr-librispeech-pruned-transducer-stateless3-2022-05-13 |
|
The rename should work. |
Unfortunately the build is now broken, I don't know what maintainers have done. |
Narsil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for fixing the bug @Narsil ! |

Context huggingface/hub-docs#552 (comment)
It's called k2_sherpa in the inference API but in the repos, people just use k2 so let's make it consistent so that the export script can work.