-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Check tied parameters #1529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check tied parameters #1529
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for those QOL improvements!
Fix log Co-authored-by: Sylvain Gugger <[email protected]>
Fix comments and tests Fix description
src/accelerate/utils/modeling.py
Outdated
| has_tied_encoder_decoder = False | ||
| has_tied_module = False | ||
|
|
||
| if transformers.modeling_utils.PreTrainedModel in inspect.getmro(model.__class__): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking on testing the class __name__ to avoid the extra dep on Transformers.
What does this PR do ?
This PR fixes two issues user can have when using big inference model:
How to test it
Issue 1
Issue 2