Skip to content

Conversation

@pacman100
Copy link
Contributor

@pacman100 pacman100 commented Mar 2, 2023

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 2, 2023

The documentation is not available anymore as the PR was closed or merged.

@pacman100 pacman100 requested a review from sgugger March 2, 2023 12:19
@pacman100 pacman100 marked this pull request as ready for review March 2, 2023 12:19
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the point of the test with DeepSpeed 0.6.5 if I may?

@pacman100
Copy link
Contributor Author

It was sort of hot fix for deepspeedai/DeepSpeed#2117. PR for it #544

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks!

@pacman100 pacman100 merged commit d88bbbd into huggingface:main Mar 2, 2023
@pacman100 pacman100 deleted the smangrul/ds-dist-init-fix branch March 3, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] - AcceleratorState initialization in DS case ignores timeout argument

3 participants