Revert "RFC 008 slice 1: walking skeleton for openenv validate"

[burtenshaw]

Reverts #1091

[bot-ci-comment]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

[cursor]

Alignment Review Report

Headline: This "Revert" changes nothing. gh pr view reports additions: 0, deletions: 0, changedFiles: 0, and the single commit aa3aa49 has a tree byte-identical to its parent 6f98b03. The openenv validate walking-skeleton code from #1091 is still present on the branch. The PR is already merged, so an empty revert now sits in rfc-008/pr2-contracts with no effect.

Automated Checks

• Lint: N/A (0 files changed) — an empty diff introduces no lint regressions. The repo-pinned linters (uv/usort/ruff via .claude/hooks/lint.sh) aren't installed on the review runner; I installed uv and ran standalone ruff for signal. ruff@latest flags repo-wide formatting deltas, but those are tool-version-dependent and pre-existing (AGENTS.md also documents pre-existing usort findings) — none attributable to this PR.
• Debug code: CLEAN for this PR — check-debug.sh reports print/TODO lines only in files this PR does not touch (src/openenv/core/containers/..., src/openenv/cli/serve.py, src/openenv/cli/__main__.py). Nothing introduced here.

Open RFCs Context

• RFC 008 — Environment Auto-Validation (Status: In Review, @zkwentz). Directly relevant: this PR sits in the RFC 008 delivery stack — base branch rfc-008/pr2-contracts ("PR2 — contracts"), reverting #1091 "RFC 008 slice 1: walking skeleton for openenv validate" (a PR3+ implementation slice, authored by @zkwentz, merged by @burtenshaw).
• No other RFCs (001–005, 010) are affected.

Tier 1: Fixes Required

• (entire PR) The revert is a no-op — it reverts nothing. Tree of aa3aa49 == tree of parent 6f98b03; 0 files/0 lines. The slice-1 code (src/openenv/cli/commands/validate.py, src/openenv/validation/**) remains on the branch.
  • Root cause: the commit this claims to revert — 3d9eac18… (the #1091 squash-merge) — is not in the current base-branch history (git branch --contains 3d9eac18 → "no such commit"; the base was rebased/rewritten by the later "refresh validation stack" commits). Reverting a commit whose changes are no longer in history produces an empty commit.
  • Impact: already merged (opened 11:04:52Z, merged 11:05:10Z — 18s later). If the goal was to roll back the walking skeleton, that did not happen.
  • Suggested follow-up: if rollback is intended, do a targeted removal (revert against the correct current commit(s), or git rm the slice-1 files) and verify openenv validate afterward. If the no-op was intentional (a rebase already dropped the slice), no code fix is needed — but consider dropping this misleading empty "Revert" commit so history stays honest.

Tier 2: Alignment Discussion

Principle Conflicts

None identified — the PR changes no code, so no PRINCIPLES.md principle or INVARIANTS.md invariant is touched.

RFC Conflicts

ALIGNMENT FLAG: Reverting an RFC 008 implementation slice off the contracts branch

• Principle/RFC at stake: RFC 008 (Environment Auto-Validation, In Review) and its stacked delivery plan (PR2 contracts → PR3+ vertical slices, "walking skeleton" first).
• The concern: The stated intent is to remove the slice-1 walking skeleton from rfc-008/pr2-contracts, but (a) nothing was actually removed (see Tier 1), and (b) even a successful removal changes how the RFC 008 stack is assembled — whether the walking skeleton should live on the contracts branch or be split back out is a design-stack decision, not a mechanical one. Please confirm the intended branch state and make it match.
• Suggested reviewer: @zkwentz (RFC 008 author + author of the reverted #1091); @burtenshaw (opened & merged this revert)

Summary

• 1 mechanical finding — the revert is empty and does not achieve its stated purpose (already merged as a no-op).
• 1 alignment point — confirm the intended RFC 008 stack state and redo the removal correctly if rollback was the goal.
• 0 principle/invariant violations (no code changed).

  

_{Sent by Cursor Automation: Pre-review}