Fixes problem where package weight was dropped #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When new package instances were being created, the weight value was not being preserved. This repairs the problem.
novawish
suggested changes
Oct 11, 2019
| weight = thispackage.weight | ||
| for dimensions in set(permutations((thispackage[0], thispackage[1], thispackage[2]))): | ||
| thispackage = Package(dimensions, nosort=True) | ||
| thispackage.weight = weight |
There was a problem hiding this comment.
Why not just putting this in the above initialization instead?
thispackage = Package(dimensions, weight=weight, nosort=True)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When new package instances were being created, the weight value was not being preserved. This repairs the problem.