add extra except for Auth errors in openai/anth calls #121
+17
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| reasoning={"summary": "auto"}, # type: ignore[arg-type] | ||
| ) | ||
| except AuthenticationError: | ||
| raise ValueError("OpenAI API key is set but is not valid.") |
There was a problem hiding this comment.
Bug: Inconsistent Error Handling Across API Calls
The AuthenticationError handling for openai_client.responses.create() is only applied to the initial conversation path. The identical API call in the else branch for follow-up steps lacks this, causing inconsistent error behavior.
|
📝 Documentation updates detected! New suggestion: Add authentication error troubleshooting guide for PR #121 |
|
can you make sure pyright and ruff checks pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.