-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blt 758 task use knowledge base on flow builder plugin #2847
Merged
Iru89
merged 15 commits into
master-lts
from
BLT-758-task-use-knowledge-base-on-flow-builder-plugin
Jun 11, 2024
Merged
Blt 758 task use knowledge base on flow builder plugin #2847
Iru89
merged 15 commits into
master-lts
from
BLT-758-task-use-knowledge-base-on-flow-builder-plugin
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iru89
force-pushed
the
BLT-758-task-use-knowledge-base-on-flow-builder-plugin
branch
4 times, most recently
from
June 10, 2024 13:32
5df2f08
to
e9718b4
Compare
vanbasten17
approved these changes
Jun 10, 2024
Base automatically changed from
plugin-hubtype-analytics/feedback-event
to
master-lts
June 11, 2024 10:30
update event flow
…ent (#2834) Review commit by commit Add events to plugin flow builder: - fallback event - keyword event - intent - intent smart
Refactor custom event to have only one custom event and to always go through the public API
* Removing data field from events --------- Co-authored-by: Oriol Raventos <[email protected]>
… new knowledge base api without id
…trackEvent functions
…eturn fallback contents if hasKnowledge or isFaithuful is false
…wBuilderPlugin function
…r receiving the response
Iru89
force-pushed
the
BLT-758-task-use-knowledge-base-on-flow-builder-plugin
branch
from
June 11, 2024 11:45
e9718b4
to
f792966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the logic for knowledge-base-node.
With version 0.27.0 of the knowledge bases plugin the id will not be used when doing the inference but you will have to indicate which sources you want to use.
Context
In a knowledge base node we have stored the names of the files (sources of the main knowledge base) that we want to use to solve the user's question.
In the knowledge base flow we can have conditionals, texts and follow ups that end up connecting to a knowledge base node
Approach taken / Explain the design
If the knowledge base response hasKnowledge or isFaithful set to false we will display the contents of fallback.
It may happen that in the knowledge base flow when solving a conditional we do not use any knowledge base, in which case the nodes are solved without using the knowledge base.
To document / Usage example
Testing
Add tests for knowledge base flows
Change createFlowBuilderPlugin function to pass a object with params, add createFlowBuilderPluginAndGetContents to encapsulate in one function all logic for most of the tests