chore(core): Remove unused code from experimental 1.0 version #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten17
changed the title
vanbasten17
force-pushed
the
feature/blt-691-task-review-botonic-core
branch
from
f475f62 to
7ca58d5
Compare
Iru89
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@botonic/core
Add functions like isWhatsapp, pass the session and check the provider. Better if they are in @botonic/core as we can use them in several packages and also in the bot.
@botonic/react
Use isWhatsapp and isFacebook from core
@botonic/dx
Add the jsdom package, in the latest version of jest it does not come by default, you need to install a separate package.
Use the tsconfig in the transform attribute of jest.config together with ts-jest. The latest version of jest cannot use this configuration in the globals attribute.
Context
Approach taken / Explain the design
To document / Usage example
Testing
The pull request...