feat(react): Add class names to buttons #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e (custom, payload, url, webview or path)
asastre
requested review from
ericmarcos,
guinii,
vanbasten17,
Iru89,
AinaVendrell and
AlbertGom
manuelfidalgo
approved these changes
Feb 22, 2022
Iru89
approved these changes
Feb 22, 2022
JianChen-IT
approved these changes
Feb 23, 2022
Merged
vanbasten17
pushed a commit
that referenced
this pull request
Mar 23, 2023
* feat(react): add specific class names in buttons depending of its type (custom, payload, url, webview or path) * fix(core): fix import error with pako package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add class names to buttons depending on their type.
Context
It can be useful sometimes to apply different styles depending on the button's destination (payload, url...) but without having fixed classes this is not possible.
Approach taken / Explain the design
Add a fixed class name to custom buttons and to normal buttons depending on the active attribute they have as a destination.
To document / Usage example
Classes created:
button-custombutton-payloadbutton-urlbutton-pathbutton-webviewTesting
The pull request has no tests.