-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cli): remove force flag, improved error handling and add cli tests #1321
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #1321 +/- ##
==========================================
+ Coverage 60.55% 63.40% +2.85%
==========================================
Files 250 250
Lines 7146 7059 -87
Branches 1199 1186 -13
==========================================
+ Hits 4327 4476 +149
+ Misses 2494 2245 -249
- Partials 325 338 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
9079d17
to
738888e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
738888e
to
fbdb87e
Compare
This comment has been minimized.
This comment has been minimized.
fbdb87e
to
a2e3029
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a2e3029
to
b06b1e1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Nice work! It is not easy to develop tests for cli
23d2370
to
c247014
Compare
This comment has been minimized.
This comment has been minimized.
c247014
to
638b80e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
638b80e
to
2c94fcf
Compare
Description
Important
If you have Jest runner set up in VS Code, it will try to run automatically tests for this package. Since the tests try to create temporary directories, it may provoke to create trash files for these tmp directories.
Please, add a
.vscode
directory inbotonic-cli/
with following configuration in order to avoid this behavior: