Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): scroll to bottom on focus on non-iphone devices #1263

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

vanbasten17
Copy link
Contributor

Description

  • Scroll to bottom when focusing an input on non-iphone devices.

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #1263 (2429292) into master (216addd) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1263      +/-   ##
==========================================
+ Coverage   64.72%   64.73%   +0.01%     
==========================================
  Files         236      236              
  Lines        6469     6471       +2     
  Branches     1118     1118              
==========================================
+ Hits         4187     4189       +2     
  Misses       1968     1968              
  Partials      314      314              
Flag Coverage Δ
botonic-react 55.28% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...otonic-react/src/webchat/devices/device-adapter.js 57.14% <100.00%> (+7.14%) ⬆️
packages/botonic-react/src/webchat/webchat.jsx 50.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216addd...2429292. Read the comment docs.

Copy link
Contributor

@elozano98 elozano98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vanbasten17 vanbasten17 merged commit c334f80 into master Jan 21, 2021
@vanbasten17 vanbasten17 deleted the fix/scroll-on-non-iphone-devices branch January 21, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants