Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nlp): Bulgarian added to contenful #1250

Merged
merged 3 commits into from
Jan 18, 2021
Merged

chore(nlp): Bulgarian added to contenful #1250

merged 3 commits into from
Jan 18, 2021

Conversation

elozano98
Copy link
Contributor

Depends on #1249. Please, review it first. ⚠️

Description

Bulgarian tokenizer, stemmer, and stopwords have been added to contentful nlp.

Context

Adding them will make it possible to process Bulgarian text.

Approach taken / Explain the design

  • The Tokenizer used is the base-tokenizer from the nlpjs library.

  • The Stemmer has been implemented having as a reference this GitHub repository.

  • The Stopwords have been collected from here.

Testing

The pull request...

  • has unit tests

@elozano98 elozano98 requested review from asastre, dpinol, vanbasten17 and ericmarcos and removed request for asastre and dpinol January 15, 2021 16:02
@elozano98 elozano98 changed the base branch from master to contentful/nl January 15, 2021 16:03
Copy link
Contributor

@vanbasten17 vanbasten17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!! 💯 💯 💯

Copy link
Contributor

@ericmarcos ericmarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #1250 (38e4179) into contentful/nl (a269138) will increase coverage by 0.11%.
The diff coverage is 88.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           contentful/nl    #1250      +/-   ##
=================================================
+ Coverage          64.62%   64.73%   +0.11%     
=================================================
  Files                232      236       +4     
  Lines               6443     6469      +26     
  Branches            1115     1118       +3     
=================================================
+ Hits                4164     4188      +24     
  Misses              1966     1966              
- Partials             313      315       +2     
Flag Coverage Δ
botonic-plugin-contentful 71.32% <88.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nlp/stemmers/transformations/transformations-bg.ts 100.00% <ø> (ø)
...c-plugin-contentful/src/nlp/stemmers/stemmer-bg.ts 81.25% <81.25%> (ø)
...kages/botonic-plugin-contentful/src/nlp/locales.ts 100.00% <100.00%> (ø)
...kages/botonic-plugin-contentful/src/nlp/stemmer.ts 95.91% <100.00%> (+0.17%) ⬆️
...lugin-contentful/src/nlp/stopwords/stopwords-bg.ts 100.00% <100.00%> (ø)
...ugin-contentful/src/nlp/tokenizers/tokenizer-bg.ts 100.00% <100.00%> (ø)
...ckages/botonic-plugin-contentful/src/nlp/tokens.ts 96.07% <100.00%> (+0.11%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a269138...38e4179. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants