Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates #1482

Merged
merged 3 commits into from
Jan 11, 2019
Merged

Dependency updates #1482

merged 3 commits into from
Jan 11, 2019

Conversation

mistydemeo
Copy link
Contributor

This makes a few changes to Hubot's dependencies:

  • coffee-script has moved to coffeescript. The old name still works, but this silences an npm warning.
  • Bump to the latest versions of both mocha and coveralls, both of which had lagged a bit behind upstream. Thankfully the tests run as-is without requiring changes.

Copy link
Member

@technicalpickles technicalpickles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could you update the commit message to use semantic-release syntax?

@technicalpickles
Copy link
Member

#1466 looks like an earlier attempt at this

@technicalpickles
Copy link
Member

I ended up merging #1466 because it had some documentations update to go with coffeescript too. This PR is still useful since it addresses other dependencies.

@mistydemeo
Copy link
Contributor Author

Rebased and updated the commit names to be semantic-release compatible.

@mistydemeo mistydemeo merged commit 067a70d into hubotio:master Jan 11, 2019
@mistydemeo mistydemeo deleted the dep_updates branch January 11, 2019 03:31
@hubotbot
Copy link

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants