Collections UI #1399
Merged
Collections UI #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibutors into a single table
…ng definitions. Provides Group Selection modal on Collection creation to assign an ownership group. Stops the idle timer when the REACT_APP_URL is http://localhost:8585 Fix generation of Action column for the Associated Entity table to reduce re-rendering calls
yuanzhou
reviewed
May 3, 2024
| resolve(); | ||
| }, 2000); | ||
| }); | ||
| if(process.env.REACT_APP_URL == "http://localhost:8585"){ |
There was a problem hiding this comment.
@BirdMachine is this for your local testing?
There was a problem hiding this comment.
Essentially. Added here Figuring out the Re Rendering that was getting in my way involved a lot of alt tabbed research (Especially since the 'bug' was also causing my React Dev Tools to Crash. The Timeout is short and having to log in each time a local or a dev tab was left open for a bit complicates things.
Will touch base on slack for a possibly slicker solution
yuanzhou
approved these changes
May 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to Ownership Group assignment/selection
Replaces Delineated Contacts/contributors table with a combined table using a column for Contact status rendering
Various fixes to table columns and values rendering