-
Notifications
You must be signed in to change notification settings - Fork 769
Add support for 'include_all_branches' flag when creating repository from a template #2107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 'include_all_branches' flag when creating repository from a template #2107
Conversation
4c84356 to
a37c814
Compare
a37c814 to
885bc95
Compare
|
sorry to tag you directly @bitwiseman, am I missing anything major (besides the build failures) in this PR? :) |
|
@leowebb |
|
Thanks a bunch! I added a branch to the test repository, github-api-template-test - if you would prefer I used a separate repository, let me know. Thanks for getting me access. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2107 +/- ##
=========================================
Coverage 85.02% 85.02%
- Complexity 2494 2495 +1
=========================================
Files 237 237
Lines 7350 7351 +1
Branches 388 388
=========================================
+ Hits 6249 6250 +1
Misses 871 871
Partials 230 230 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bitwiseman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
Hi there! I've added support for a flag in the API call here when creating a repository from a template repository. Specifically, I've added just the flag to include all branches when using the template repository.
This is my first contribution, so I was hoping to get access to the
hub4j-test-orgto generate the necessary test files that I can add with my check-in (along with adding a branch to the template to confirm the behavior here).I've done testing locally/against repositories within my own account, and it seemed to work well - just need access now to capture the correct snapshots.
Thanks for this awesome SDK!
Before submitting a PR:
@linkJavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED"locally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: