Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform CI code coverage in Java 11 #1304

Merged
merged 4 commits into from
Nov 20, 2021

Conversation

bitwiseman
Copy link
Member

Description

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than main. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

The resulting ouput reports coverage numbers for HttpClientGitHubConnector, but points to
the wrong file. Bummer, but at least the numbers are right.
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #1304 (027d19a) into main (d46bca7) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1304      +/-   ##
============================================
- Coverage     77.89%   77.86%   -0.04%     
+ Complexity     2012     2009       -3     
============================================
  Files           197      197              
  Lines          6219     6215       -4     
  Branches        359      359              
============================================
- Hits           4844     4839       -5     
- Misses         1161     1162       +1     
  Partials        214      214              
Impacted Files Coverage Δ
...suke/github/connector/GitHubConnectorResponse.java 100.00% <ø> (ø)
...tHubConnectorResponseHttpUrlConnectionAdapter.java 86.15% <0.00%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d46bca7...027d19a. Read the comment docs.

@bitwiseman bitwiseman marked this pull request as ready for review November 20, 2021 03:55
@bitwiseman bitwiseman merged commit e403ce4 into hub4j:main Nov 20, 2021
@bitwiseman bitwiseman changed the title Task/codecoverage11 Perform CI code coverage in Java 11 Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant