Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Accept header to reasonable default #1289

Merged
merged 2 commits into from
Nov 8, 2021

Conversation

bitwiseman
Copy link
Member

Description

The Accept header should default to a reasonable default. This also makes the test resources for OkHttpClient and HttpURLConnection the same, allowing for better test coverage.

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than main. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #1289 (260ae86) into main (eef3c58) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1289   +/-   ##
=========================================
  Coverage     77.50%   77.50%           
- Complexity     1905     1906    +1     
=========================================
  Files           189      189           
  Lines          6000     6002    +2     
  Branches        328      329    +1     
=========================================
+ Hits           4650     4652    +2     
  Misses         1150     1150           
  Partials        200      200           
Impacted Files Coverage Δ
src/main/java/org/kohsuke/github/GitHubClient.java 89.47% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef3c58...260ae86. Read the comment docs.

@bitwiseman bitwiseman merged commit 0601578 into hub4j:main Nov 8, 2021
@bitwiseman bitwiseman deleted the task/accept branch November 8, 2021 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant