Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update okhttp to 4.9.2 #1281

Merged
merged 5 commits into from
Nov 2, 2021
Merged

Update okhttp to 4.9.2 #1281

merged 5 commits into from
Nov 2, 2021

Conversation

bitwiseman
Copy link
Member

@bitwiseman bitwiseman commented Nov 2, 2021

Description

Okhttp 4.9.2 looks like it works. The only oddity is the change the ETag caching behavior.

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than main. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #1281 (0940530) into main (4bfa0ed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1281   +/-   ##
=========================================
  Coverage     77.50%   77.50%           
  Complexity     1905     1905           
=========================================
  Files           189      189           
  Lines          6000     6000           
  Branches        328      328           
=========================================
  Hits           4650     4650           
  Misses         1150     1150           
  Partials        200      200           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfa0ed...0940530. Read the comment docs.

@bitwiseman bitwiseman marked this pull request as draft November 2, 2021 16:30
@bitwiseman bitwiseman force-pushed the bitwiseman-patch-2 branch 2 times, most recently from 5af6bd7 to 7d3c5b8 Compare November 2, 2021 21:08
@bitwiseman bitwiseman force-pushed the bitwiseman-patch-2 branch 2 times, most recently from e24886d to 35960ad Compare November 2, 2021 21:41
@bitwiseman bitwiseman changed the title Update okhttp to 4.9.1 Update okhttp to 4.9.2 Nov 2, 2021
@bitwiseman bitwiseman marked this pull request as ready for review November 2, 2021 21:49
@bitwiseman bitwiseman requested a review from timja November 2, 2021 21:50
@bitwiseman bitwiseman merged commit 913a2ed into main Nov 2, 2021
@bitwiseman bitwiseman deleted the bitwiseman-patch-2 branch November 2, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants