Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom lane offset ranges in the ULTRA task configs #683

Merged
merged 3 commits into from
Mar 17, 2021

Conversation

christianjans
Copy link
Contributor

@christianjans christianjans commented Mar 16, 2021

Allows for the ability to set the vehicle's initial position in the start lane, and also its end position in the end lane by specifying a range [min, max] for the start_offset and end_offset.

When generating a scenario, the missions generate a random start offset integer and end offset integer in the range [min, max]. This determines how far along the start lane the vehicle will be spawned in (in the case of the start offset), and how far along the end lane the vehicle has to go to reach its goal (in the case of the end offset).

@AlexLewandowski and @JenishPatel99, should start_offset and end_offset be optional fields for ego_missions or should these be explicitly defined (like they are now)? Let me know your thoughts on this, and anything else regarding these changes.

@christianjans christianjans added the ULTRA Tickets related to Unprotected Left Turns label Mar 16, 2021
@christianjans christianjans linked an issue Mar 16, 2021 that may be closed by this pull request
@christianjans christianjans changed the title Add ability to set lane offset ranges in the ULTRA task configs Add custom lane offset ranges in the ULTRA task configs Mar 16, 2021
@JenishPatel99
Copy link
Contributor

JenishPatel99 commented Mar 16, 2021

@christianjans I believe it is a nice fine adjustment to control the initial position of the vehicle. Although, I may feel that the config files may get a bit crowded, and for cases where people may choose not to change the offset (from default), we should provide a default setting; i.e if there is no offset values provided in the config files then you use the defaults

@christianjans
Copy link
Contributor Author

@christianjans I believe it is a nice fine adjustment to control the initial position of the vehicle. Although, I may feel that the config files may get a bit crowded, and for cases where people may choose not to change the offset (from default), we should provide a default setting; i.e if there is no offset values provided in the config files then you use the defaults

Oh good call, I will ensure there is a default and remove the changes in the configs.

@christianjans christianjans merged commit 028bf22 into develop Mar 17, 2021
@christianjans christianjans deleted the ultra_custom_mission_offset branch March 17, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ULTRA Tickets related to Unprotected Left Turns
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for custom offset in ULTRA ego missions' routes
3 participants