-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ci error #648
Fix ci error #648
Conversation
f58e8af
to
13a1582
Compare
To reproduce the failing CI test locally, create two venvs, one based on smarts ci and one based on Ultra's CI:
then Create venv according to Ultra's CI:
then run
|
@JingfeiPeng I have managed to suppress the ultra ci error by upgrading the numpy package. A stackexchange thread seemed to give a solution here is the link https://stackoverflow.com/questions/33859531/runtimeerror-module-compiled-against-api-version-a-but-this-version-of-numpy-is |
.github/workflows/ci-base-tests.yml
Outdated
on: | ||
push: | ||
branches: | ||
- disabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would disable the tests right? We probably want to fix it instead of disabling it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry I forgot to enable those tests after just testing the ultra-ci by itself. I have restored the others tests as well
We should merge this into both develop and master. |
fixed ci tests on smarts side, still needs to figure out how to fix ci test on Ultra side