Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci error #648

Merged
merged 6 commits into from
Mar 7, 2021
Merged

Fix ci error #648

merged 6 commits into from
Mar 7, 2021

Conversation

JingfeiPeng
Copy link
Contributor

fixed ci tests on smarts side, still needs to figure out how to fix ci test on Ultra side

@Gamenot Gamenot linked an issue Mar 5, 2021 that may be closed by this pull request
@JingfeiPeng
Copy link
Contributor Author

JingfeiPeng commented Mar 5, 2021

To reproduce the failing CI test locally, create two venvs, one based on smarts ci and one based on Ultra's CI:

python3.7 -m venv .first
. .first/bin/activate
pip install --upgrade pip
pip install --upgrade wheel
pip install --upgrade -r requirements.txt
pip install --upgrade -e .[train,test]

then cd ultra and run pytest tests/test_train.py the test passes

Create venv according to Ultra's CI:

cd ultra
python3.7 -m venv .second
. .second/bin/activate
pip install --upgrade --upgrade-strategy eager pip
pip install --upgrade -e .

then run pytest tests/test_train.py we can reproduce the numpy import error

.ultra_venv/lib/python3.7/site-packages/smarts/core/utils/pybullet.py:27: in <module>
    from pybullet import *
E   ImportError: numpy.core.multiarray failed to import

@JenishPatel99
Copy link
Contributor

@JingfeiPeng I have managed to suppress the ultra ci error by upgrading the numpy package. A stackexchange thread seemed to give a solution here is the link https://stackoverflow.com/questions/33859531/runtimeerror-module-compiled-against-api-version-a-but-this-version-of-numpy-is

on:
push:
branches:
- disabled
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would disable the tests right? We probably want to fix it instead of disabling it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry I forgot to enable those tests after just testing the ultra-ci by itself. I have restored the others tests as well

@Gamenot
Copy link
Collaborator

Gamenot commented Mar 7, 2021

We should merge this into both develop and master.

@JingfeiPeng JingfeiPeng changed the title WIP Fix ci error Fix ci error Mar 7, 2021
@JingfeiPeng JingfeiPeng merged commit 5fd75a9 into develop Mar 7, 2021
@JingfeiPeng JingfeiPeng mentioned this pull request Mar 7, 2021
@JingfeiPeng JingfeiPeng deleted the fix_ci_error branch April 13, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failure
3 participants