Fix add ijson to setup #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingfeiPeng
approved these changes
Mar 5, 2021
|
I initially added ijson in requirements.txt. Are we adding it in setup.py because if people install smarts package, dependencies in requirements.txt wouldn't be installed, and to install ijson when installing smarts package, we have to add it in setup.py? |
Yes it needs to be in setup.py or it will not be added to the package when we build it. |
Adaickalavan
approved these changes
Mar 8, 2021
Gamenot
force-pushed
the
fix-add_ijson_to_setup
branch
from
1532e5f to
9e7b87a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.