Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ultra #380

Merged
merged 15 commits into from
Jan 6, 2021
Merged

Ultra #380

merged 15 commits into from
Jan 6, 2021

Conversation

adreena
Copy link
Collaborator

@adreena adreena commented Jan 5, 2021

I'm adding ultra changes under smarts/ultra

Gamenot
Gamenot reviewed Jan 6, 2021
View reviewed changes
@adreena adreena merged commit 65451a3 into huawei-noah:ultra Jan 6, 2021
AlexLewandowski
AlexLewandowski reviewed Jan 6, 2021
View reviewed changes
Copy link
Contributor

@AlexLewandowski AlexLewandowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are still references to smarts.ultra.registry in train.py and evaluate.py

@Gamenot
Copy link
Collaborator

Gamenot commented Jan 6, 2021

@AlexLewandowski , thank you for spotting that.

@Gamenot Gamenot mentioned this pull request Jan 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexLewandowski AlexLewandowski AlexLewandowski left review comments

@Gamenot Gamenot Gamenot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adreena @Gamenot @AlexLewandowski